Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use ssr dynamic offset in volumetric fog bind group #13544

Merged
merged 1 commit into from
May 27, 2024
Merged

use ssr dynamic offset in volumetric fog bind group #13544

merged 1 commit into from
May 27, 2024

Conversation

mockersf
Copy link
Member

Objective

wgpu error: Validation Error

Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(2, 4, Metal)>`
    In a set_bind_group command
      note: bind group = `mesh_view_bind_group`
    Bind group 0 expects 5 dynamic offsets. However 4 dynamic offsets were provided.

Solution

  • add ssr offset to volumetric fog bind group

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels May 27, 2024
@mockersf mockersf added this to the 0.14 milestone May 27, 2024
@mockersf mockersf requested a review from pcwalton May 27, 2024 21:06
@pcwalton pcwalton mentioned this pull request May 27, 2024
Closed
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 27, 2024
@mockersf mockersf added this pull request to the merge queue May 27, 2024
Merged via the queue into bevyengine:main with commit 2e8abee May 27, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcwalton pcwalton pcwalton approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @pcwalton @IceSentry